yasserzamani commented on a change in pull request #510:
URL: https://github.com/apache/struts/pull/510#discussion_r756367859
##########
File path: core/src/main/java/org/apache/struts2/views/jsp/ui/AbstractUITag.java
##########
@@ -90,7 +93,11 @@ protected void populateParams() {
uiBean.setDisabled(disabled);
uiBean.setLabel(label);
uiBean.setLabelSeparator(labelSeparator);
- uiBean.setLabelPosition(labelPosition);
+ if (labelposition != null) {
Review comment:
Not sure but since labelposition is deprecated, shouldn't we check for
`labelPosition` here instead? to give it preference and priority higher than
the deprecated one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
