[
https://issues.apache.org/jira/browse/WW-5165?focusedWorklogId=771338&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-771338
]
ASF GitHub Bot logged work on WW-5165:
--------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/22 13:25
Start Date: 17/May/22 13:25
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #552:
URL: https://github.com/apache/struts/pull/552#discussion_r874808304
##########
core/pom.xml:
##########
@@ -242,6 +242,16 @@
<artifactId>spring-web</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
Review Comment:
background: Add spring-context for testing with StaticApplicationContext
##########
plugins/portlet-mocks/pom.xml:
##########
@@ -51,6 +51,7 @@
</dependencies>
<properties>
+ <spring.platformVersion>4.3.30.RELEASE</spring.platformVersion>
Review Comment:
good idea, to freeze the spring version here
##########
plugins/portlet/pom.xml:
##########
@@ -130,11 +130,7 @@
<artifactId>spring-test</artifactId>
<optional>true</optional>
</dependency>
- <dependency>
Review Comment:
Maybe we could add some additional infos to the commit to clarify the context
Remove unused spring-webmvc-portlet
Spring 5.x dropped support for spring-webmvc-portlet
https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-5.x#dropped-support
Issue Time Tracking
-------------------
Worklog Id: (was: 771338)
Time Spent: 2h 10m (was: 2h)
> Update spring to 5.3.x b/c 4.3.x is EOL
> ---------------------------------------
>
> Key: WW-5165
> URL: https://issues.apache.org/jira/browse/WW-5165
> Project: Struts 2
> Issue Type: Dependency
> Reporter: Sebastian Peters
> Priority: Major
> Fix For: 2.6
>
> Original Estimate: 0.5h
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> see
> https://spring.io/blog/2019/12/03/spring-framework-maintenance-roadmap-in-2020-including-4-3-eol
> In addition 4.3.x lists several CVEs according to
> https://mvnrepository.com/artifact/org.springframework/spring-core/4.3.30.RELEASE
> that are fixed with the newest version
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
