brianandle commented on code in PR #557:
URL: https://github.com/apache/struts/pull/557#discussion_r889000642
##########
core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java:
##########
@@ -58,6 +64,9 @@ public class ParametersInterceptor extends
MethodFilterInterceptor {
private ValueStackFactory valueStackFactory;
private ExcludedPatternsChecker excludedPatterns;
private AcceptedPatternsChecker acceptedPatterns;
+ private Set<Pattern> excludedValuePatterns = null;
+ private Set<Pattern> acceptedValuePatterns = null;
Review Comment:
ExcludedPatternsChecker and AcceptedPatternsChecker are used by the Cookie
and Parameter Interceptor and are really targeted to the name aspects and not
values, including the default exclude/accepts.
Given this is specific to param values, and I don't see a reuse case I
didn't abstract it to new ExcludedValuePatternsChecker and
AcceptedValuePatternsChecker classes, as it would be abstraction without more
than a single use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
