[jira] [Work logged] (WW-5191) template/simple/textarea.ftl not rendering parameters correctly

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5191?focusedWorklogId=781719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781719
 ]

ASF GitHub Bot logged work on WW-5191:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jun/22 16:00
            Start Date: 15/Jun/22 16:00
    Worklog Time Spent: 10m 
      Work Description: coveralls commented on PR #572:
URL: https://github.com/apache/struts/pull/572#issuecomment-1156655027

   
   [![Coverage 
Status](https://coveralls.io/builds/50057837/badge)](https://coveralls.io/builds/50057837)
   
   Coverage increased (+0.01%) to 50.645% when pulling 
**0e4d5962e1d774d6791b2f713263d9e9fcd41aab on WW-5191-textarea-max-length** 
into **ba041e1ee68fa68b8bcf95a081846c4cce4a47fe on master**.
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 781719)
    Time Spent: 20m  (was: 10m)

> template/simple/textarea.ftl not rendering parameters correctly
> ---------------------------------------------------------------
>
>                 Key: WW-5191
>                 URL: https://issues.apache.org/jira/browse/WW-5191
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Tags
>    Affects Versions: 6.0.0
>            Reporter: Burton Rhodes
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 6.0.1
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The "simple" textarea.ftl (I haven't checked the other templates) does not 
> have the ending ">" in the correct location. As a result, maxlength and 
> minlength are displayed within the textarea editor.
>  
> *Current*
> {code:java}
> <#include 
> "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include 
> "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl" 
> />
> <#include 
> "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl" 
> />
> ><#rt/>    <#--  !! WRONG LOCATION !! -->
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> </textarea> {code}
>  
> *Should be* 
> {code:java}
> <#include 
> "/${parameters.templateDir}/${parameters.expandTheme}/scripting-events.ftl" />
> <#include 
> "/${parameters.templateDir}/${parameters.expandTheme}/common-attributes.ftl" 
> />
> <#include 
> "/${parameters.templateDir}/${parameters.expandTheme}/dynamic-attributes.ftl" 
> />
> <#if parameters.nameValue??>
> <@s.property value="parameters.nameValue"/><#t/>
> </#if>
> <#if parameters.maxlength?has_content>
> maxlength="${parameters.maxlength}"<#rt/>
> </#if>
> <#if parameters.minlength?has_content>
> minlength="${parameters.minlength}"<#rt/>
> </#if>
> ><#rt/> <#-- !! CORRECT LOCATION !! -->
> </textarea>{code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)