sepe81 commented on code in PR #585:
URL: https://github.com/apache/struts/pull/585#discussion_r940646553
##########
core/src/main/java/org/apache/struts2/dispatcher/ApplicationMap.java:
##########
@@ -167,24 +128,26 @@ public Object get(Object key) {
* @param value the value to set.
* @return the attribute that was just set.
*/
- public Object put(Object key, Object value) {
- Object oldValue = get(key);
- entries = null;
- context.setAttribute(key.toString(), value);
- return oldValue;
- }
+ public Object put(final String key, final Object value) {
Review Comment:
fix tabs to spaces for method put
##########
core/src/main/java/org/apache/struts2/dispatcher/StringObjectEntry.java:
##########
@@ -0,0 +1,46 @@
+package org.apache.struts2.dispatcher;
+
+import java.util.Map.Entry;
+
+abstract class StringObjectEntry implements Entry<String, Object> {
+ private String key;
+ private Object value;
+
+ public StringObjectEntry(final String key, final Object value) {
Review Comment:
```suggestion
StringObjectEntry(final String key, final Object value) {
```
see sonar rule java:S5993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
