[
https://issues.apache.org/jira/browse/WW-5279?focusedWorklogId=842322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842322
]
ASF GitHub Bot logged work on WW-5279:
--------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/23 16:24
Start Date: 30/Jan/23 16:24
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #657:
URL: https://github.com/apache/struts/pull/657#discussion_r1090851725
##########
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java:
##########
@@ -439,28 +445,16 @@ protected void addAction(Element actionElement,
PackageConfig.Builder packageCon
String name = actionElement.getAttribute("name");
String className = actionElement.getAttribute("class");
//methodName should be null if it's not set
- String methodName =
StringUtils.trimToNull(actionElement.getAttribute("method"));
+ String methodName = trimToNull(actionElement.getAttribute("method"));
Location location = DomHelper.getLocationObject(actionElement);
if (location == null) {
LOG.warn("Location null for {}", className);
}
- // if there isn't a class name specified for an <action/> then try to
- // use the default-class-ref from the <package/>
- if (StringUtils.isEmpty(className)) {
- // if there is a package default-class-ref use that, otherwise use
action support
- /* if (StringUtils.isNotEmpty(packageContext.getDefaultClassRef()))
{
- className = packageContext.getDefaultClassRef();
- } else {
- className = ActionSupport.class.getName();
- }*/
-
- } else {
- if (!verifyAction(className, name, location)) {
- LOG.error("Unable to verify action [{}] with class [{}], from
[{}]", name, className, location);
- return;
- }
+ if (!className.isEmpty() && !verifyAction(className, name, location)) {
Review Comment:
Maybe we can remove the unused param `name` from verifyAction L:490
Sonar says: Parameter 'name' is never used
##########
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java:
##########
@@ -164,13 +174,10 @@ public boolean equals(Object o) {
if (this == o) {
return true;
}
-
if (!(o instanceof XmlConfigurationProvider)) {
return false;
}
-
- final XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
-
+ XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
Review Comment:
```suggestion
final XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
```
this could remain final
Issue Time Tracking
-------------------
Worklog Id: (was: 842322)
Time Spent: 20m (was: 10m)
> Improve readability of XmlConfigurationProvider class
> -----------------------------------------------------
>
> Key: WW-5279
> URL: https://issues.apache.org/jira/browse/WW-5279
> Project: Struts 2
> Issue Type: Task
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Trivial
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
