kusalk commented on code in PR #657:
URL: https://github.com/apache/struts/pull/657#discussion_r1090875321
##########
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java:
##########
@@ -164,13 +174,10 @@ public boolean equals(Object o) {
if (this == o) {
return true;
}
-
if (!(o instanceof XmlConfigurationProvider)) {
return false;
}
-
- final XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
-
+ XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
Review Comment:
I find it clutters the code and goes against [present common
practice](https://stackoverflow.com/questions/154314/when-should-one-use-final-for-method-parameters-and-local-variables)
- but I can revert these changes if that is the preferred code style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
