[GitHub] [struts] lukaszlenart commented on a diff in pull request #657: WW-5279 Improve readability of XmlConfigurationProvider class

[via GitHub]

lukaszlenart commented on code in PR #657:
URL: https://github.com/apache/struts/pull/657#discussion_r1091924829


##########
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java:
##########
@@ -164,13 +174,10 @@ public boolean equals(Object o) {
         if (this == o) {
             return true;
         }
-
         if (!(o instanceof XmlConfigurationProvider)) {
             return false;
         }
-
-        final XmlConfigurationProvider xmlConfigurationProvider = 
(XmlConfigurationProvider) o;
-
+        XmlConfigurationProvider xmlConfigurationProvider = 
(XmlConfigurationProvider) o;

Review Comment:
   I'm fine with dropping `final` in this context, I like using `final`s for 
fields and function arguments, where it makes sense :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@struts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org