[ 
https://issues.apache.org/jira/browse/WW-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694344#comment-17694344
 ] 

Kusal Kithul-Godage commented on WW-5285:
-----------------------------------------

[~lukaszlenart]

Makes sense - so `struts.multipart.maxFiles` is in a way intended to be a 
security option to prevent the parsing of a request with over a certain number 
of files.

So is there no similar need based on a file's max size? This was my intention 
with WW-5266. Given the existence of 
`org.apache.commons.fileupload.FileUploadBase#setFileSizeMax`, it would be a 
trivial addition - if you think it is worthwhile that is.

> Upgrade commons-fileupload to ver 1.5 and add option to limit number of 
> accepted files
> --------------------------------------------------------------------------------------
>
>                 Key: WW-5285
>                 URL: https://issues.apache.org/jira/browse/WW-5285
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 6.2.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> With a new version of commons-fileupload a new option has been added to limit 
> number of uploaded files (not size, but number). It would be good to support 
> this in Struts as well by adding a new constant "struts.multipart.maxFiles"
> [https://github.com/apache/commons-fileupload/pull/185]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to