[
https://issues.apache.org/jira/browse/WW-5267?focusedWorklogId=848336&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848336
]
ASF GitHub Bot logged work on WW-5267:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/23 13:41
Start Date: 01/Mar/23 13:41
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #663:
URL: https://github.com/apache/struts/pull/663#discussion_r1121748372
##########
core/src/test/java/org/apache/struts2/dispatcher/PrepareOperationsTest.java:
##########
@@ -73,6 +73,7 @@ public void testWrappedRequestCleanup() {
});
IntStream.range(0, mockedRecursions - 1).forEach(i ->
prepare.cleanupWrappedRequest(req));
+ // Assert org.apache.struts2.dispatcher.Dispatcher#cleanUpRequest has
not yet run
Review Comment:
This comment was meant to clarify the intent of line 77. This unit test is
testing that if prepare#wrapRequest is run X times, then
prepare#cleanupWrappedRequest must also be run X times before the request is
cleaned up. We do not want to clean up too early (line 77) and we don't want to
forget to clean up (line 79).
Issue Time Tracking
-------------------
Worklog Id: (was: 848336)
Time Spent: 1h 20m (was: 1h 10m)
> Add configuration option to generate ActionContext even for excluded urls
> -------------------------------------------------------------------------
>
> Key: WW-5267
> URL: https://issues.apache.org/jira/browse/WW-5267
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There are scenarios where you may want to except a request from Struts
> filtering/processing using `struts.action.excludePattern`, however you may
> still want that request to undergo filtering such as SiteMesh, which requires
> the ActionContext to be present.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
