[
https://issues.apache.org/jira/browse/WW-5290?focusedWorklogId=848917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848917
]
ASF GitHub Bot logged work on WW-5290:
--------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/23 11:55
Start Date: 03/Mar/23 11:55
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #666:
URL: https://github.com/apache/struts/pull/666#discussion_r1124354941
##########
core/src/test/java/org/apache/struts2/dispatcher/DispatcherTest.java:
##########
@@ -287,9 +283,6 @@ public void testInterceptorDestroy() {
Mock mockContainer = new Mock(Container.class);
mockContainer.matchAndReturn("getInstance",
C.args(C.eq(ObjectFactory.class)), new ObjectFactory());
- String reloadConfigs = container.getInstance(String.class,
StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD);
- mockContainer.expectAndReturn("getInstance",
C.args(C.eq(String.class),
C.eq(StrutsConstants.STRUTS_CONFIGURATION_XML_RELOAD)),
Review Comment:
We no longer expect a 2nd reload in these tests as it was unnecessary.
Issue Time Tracking
-------------------
Worklog Id: (was: 848917)
Time Spent: 20m (was: 10m)
> Refactor ConfigurationManager
> -----------------------------
>
> Key: WW-5290
> URL: https://issues.apache.org/jira/browse/WW-5290
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 6.1.1
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This class needs an overhaul:
> * Readability
> * Performance
> * Thread safety
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
