JCgH4164838Gh792C124B5 commented on PR #688: URL: https://github.com/apache/struts/pull/688#issuecomment-1556042113
Hello Apache Struts Team. The commit summary basically covers what is being attempted in the PR. Other than some minor cleanup (in the modules where changes were made), the changes were an attempt to fix the issue found with WW-5312. The regression tests pass (locally), as well as interactive testing using the Struts2 Showcase application, but the changes might still need improvements. The ```SessionMap``` method signature changes appear to be needed no matter what, though, in order to ensure the descendant method gets called even when type erasure takes place (and having the ```@Override``` annotations present should help ensure the method signatures stay consistent). Please review and advise if the PR looks OK, and if there are any recommended changes. _Note_: It looks like there was a "sonar-maven-plugin" failure for the Java 11 build environment run, but the build itself seems to have completed OK. Possibly an issue with the automated build ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
