[
https://issues.apache.org/jira/browse/WW-5301?focusedWorklogId=861930&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861930
]
ASF GitHub Bot logged work on WW-5301:
--------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/23 07:25
Start Date: 22/May/23 07:25
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #687:
URL: https://github.com/apache/struts/pull/687#discussion_r1200071200
##########
core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java:
##########
@@ -109,6 +108,8 @@ public class Dispatcher {
public static final String MULTIPART_FORM_DATA_REGEX =
"^multipart/form-data(?:\\s*;\\s*boundary=[0-9a-zA-Z'()+_,\\-./:=?]{1,70})?(?:\\s*;\\s*charset=[a-zA-Z\\-0-9]{3,14})?";
+ private static final String CONFIG_SPLIT_REGEX = "\\s*,\\s*";
Review Comment:
👏
##########
core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java:
##########
@@ -554,6 +566,7 @@ public void init() {
init_CustomConfigurationProviders(); // [5]
init_FilterInitParameters(); // [6]
init_AliasStandardObjects(); // [7]
+ init_DeferredXmlConfigurations();
Review Comment:
Nice, do you plan document this functionality in the docs?
Issue Time Tracking
-------------------
Worklog Id: (was: 861930)
Time Spent: 20m (was: 10m)
> Impossible to select alternate default VelocityManager bean
> -----------------------------------------------------------
>
> Key: WW-5301
> URL: https://issues.apache.org/jira/browse/WW-5301
> Project: Struts 2
> Issue Type: Bug
> Components: Core, Plugin - Velocity
> Affects Versions: 6.1.1
> Reporter: Kusal Kithul-Godage
> Priority: Major
> Fix For: 6.2.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I'm possibly missing something here but as far as I can tell
> struts-plugin.xml is always loaded before struts.xml.
> This means the default VelocityManager bean (#registerBeanSelection) will
> always be selected before the default bean can be configured via
> {{struts.velocity.manager.classname}}
> Changing the load order here probably isn't a good solution either.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
