lukaszlenart commented on code in PR #688:
URL: https://github.com/apache/struts/pull/688#discussion_r1208386567
##########
core/src/main/java/org/apache/struts2/interceptor/ExecuteAndWaitInterceptor.java:
##########
@@ -394,7 +404,10 @@ public void init() {
@Override
public void destroy() {
- super.destroy();
- executor.shutdown();
+ try {
+ executor.shutdown();
+ } finally {
+ super.destroy();
+ }
Review Comment:
Thanks a lot for your comment, yet I was thinking about redesigning the
current *Map approach (there is ApplicationMap, RequestMap as well) and use
native objects to have more control over them. Right now we must prevent extra
cuotion to secure the framweork (excluded `#application` or `#request` in
ParametersInterceptor).
Anyway this will happen in Struts 7.0 at leas :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
