[ https://issues.apache.org/jira/browse/WW-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727123#comment-17727123 ]
nikos dimitrakas commented on WW-5310: -------------------------------------- Here is an example of a url with a complex fragment: [http://www.google.se/books?hl=en&lr=&id=UxyXBQAAQBAJ&oi=fnd&pg=PA98&ots=pOt6UqtxNW&sig=oodVicap-mmch-iZpYQIfF3TGwY&redir_esc=y#v=twopage&q&f=false] And an alternative with the fragment identifier containing escaped characters: [https://books.google.se/books?hl=en&lr&id=UxyXBQAAQBAJ&oi=fnd&pg=PA98&ots=pOt6UqtxNW&sig=oodVicap-mmch-iZpYQIfF3TGwY&redir_esc=y&pli=1#v=snippet&q=Deng%20%26%20Wang&f=false] > s:url does not handle equal sign correctly > ------------------------------------------ > > Key: WW-5310 > URL: https://issues.apache.org/jira/browse/WW-5310 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags > Affects Versions: 2.5.30, 6.1.2 > Reporter: nikos dimitrakas > Priority: Major > Fix For: 6.2.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > We discovered a strange case when a URL is passed to s:url. The URL contains > an equal sign as part of a parameter value. Example: > [https://www.scitepress.org/PublicationsDetail.aspx?ID=GjTu91suYQI=&t=1] > This URL works in the browser even though the equal sign that is part of the > value of the parameter ID has not been replaced with %3D. > When this URL is passed to an s:url as value then the equal sign disappears. > When I put a break point in ComponentTagSupport.doStartTag() I can see that > the query string has been split and the component.parameters contains the two > parameters (ID and t), but the equal sign is missing. > The problem seems to be in ServletUrlRenderer.mergeRequestParameters called > from beforeRenderUrl. The way the StrutsQueryStringParser.parse splits each > param of the queryString on equal sign causes all the equal signs to be used, > not just the first. Shouldn't that split be only on the first equal sign so > that any remaining equal signs can be considered as part of the value? Just > by adding a limit of one to the split should fix this. -- This message was sent by Atlassian Jira (v8.20.10#820010)