nikosdimitrakas commented on PR #692: URL: https://github.com/apache/struts/pull/692#issuecomment-1600326076
For me , it would have made more sense to handle the fragment identifier outside the QueryStringParser, as the fragment identifier is technically not part of the query string. That way you could keep the backwards compatibility. To avoid having to extract the fragment identifier in multiple places (even though it would only be a couple of lines) you could have some URLSplitter class with static methods like String getQueryString(String url) and String getFragmentIdentifier(String url). Then send the query string (and only the query string) to the QueryStringParser. That said, I think you way will do the job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
