[ 
https://issues.apache.org/jira/browse/WW-5331?focusedWorklogId=876735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-876735
 ]

ASF GitHub Bot logged work on WW-5331:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Aug/23 08:31
            Start Date: 17/Aug/23 08:31
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #727:
URL: https://github.com/apache/struts/pull/727#issuecomment-1681862426

   SonarCloud Quality Gate failed.    [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=727)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=727&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=727&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=727&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=727&resolved=false&types=CODE_SMELL)
   
   
[![65.5%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'65.5%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=727&metric=new_coverage&view=list)
 [65.5% 
Coverage](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=727&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=727&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=727&metric=new_duplicated_lines_density&view=list)
   
   
![warning](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning-16px.png
 'warning') The version of Java (11.0.20) you have used to run this analysis is 
deprecated and we will stop accepting it soon. Please update to at least Java 
17.
   Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
   
   
   
   
   
![idea](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 'idea') Catch issues before they fail your Quality Gate with our IDE extension 
![sonarlint](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 'sonarlint') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)




Issue Time Tracking
-------------------

    Worklog Id:     (was: 876735)
    Time Spent: 0.5h  (was: 20m)

> Access to request attributes via tags is broken
> -----------------------------------------------
>
>                 Key: WW-5331
>                 URL: https://issues.apache.org/jira/browse/WW-5331
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Tags
>    Affects Versions: 6.2.0
>            Reporter: Wyatt Tellis
>            Priority: Major
>             Fix For: 6.3.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Accessing request attributes no longer works consistently in 6.2.0.  If you 
> have the following code:
> {{<%@ page contentType="text/html; charset=UTF-8" %>}}
> {{<%@taglib uri="http://java.sun.com/jsp/jstl/core"; prefix="c" %>}}
> {{<%@ taglib prefix="s" uri="/struts-tags" %>}}
> {{<html>}}
> {{    <head>}}
> {{        <title><s:text name="hello.message"/></title>}}
> {{    </head>}}
> {{    <body>}}
> {{        <c:set var="first" value="success" scope="request" />}}
> {{        <p>Set attempt #1: <s:property value="#request.first" /></p>}}
> {{        <c:set var="second" value="success" scope="request" />}}
> {{        <p>Set attempt #2: <s:property value="#request.second" /></p>}}
> {{    </body>}}
> {{</html>}}
>  
> On 6.1.2.1 you get:
> {{Set attempt #1: success}}
> {{Set attempt #2: success}}
> But on 6.2.0 you only get: 
> {{Set attempt #1: success}}
> {{Set attempt #2: }}
>  
> Related to: WW-5196
> Change
> {{public Object get(final String key) {}}
> {{    return request.getAttribute(key);}}
> {{}}}
> to:
> {{public Object get(final Object key) {}}
> {{    return request.getAttribute(key.toString());}}
> {{}}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to