[
https://issues.apache.org/jira/browse/WW-5334?focusedWorklogId=877068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877068
]
ASF GitHub Bot logged work on WW-5334:
--------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/23 17:11
Start Date: 18/Aug/23 17:11
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #732:
URL: https://github.com/apache/struts/pull/732#discussion_r1298678040
##########
plugins/portlet-junit/README.md:
##########
@@ -0,0 +1,5 @@
+# Struts 2 Portlet JUnit plugin
+The Portlet JUnit Plugin supports testing applications that use the Portlet
Plugin.
+
+## Installation
+Just drop this plugin JAR into `WEB-INF/lib` folder or add it as a Maven
dependency.
Review Comment:
I would remove this section
##########
plugins/portlet-junit/pom.xml:
##########
@@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <groupId>org.apache.struts</groupId>
+ <artifactId>struts2-plugins</artifactId>
+ <version>6.3.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>struts2-portlet-junit-plugin</artifactId>
+ <packaging>jar</packaging>
+ <name>DEPRECATED: Struts 2 Portlet JUnit Plugin - since 6.4.0</name>
Review Comment:
`since 6.3.0`?
Issue Time Tracking
-------------------
Worklog Id: (was: 877068)
Time Spent: 2h 10m (was: 2h)
> Misc VelocityManager code cleanup
> ---------------------------------
>
> Key: WW-5334
> URL: https://issues.apache.org/jira/browse/WW-5334
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Velocity
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
