[
https://issues.apache.org/jira/browse/WW-5343?focusedWorklogId=892109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892109
]
ASF GitHub Bot logged work on WW-5343:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/23 14:01
Start Date: 24/Nov/23 14:01
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #791:
URL: https://github.com/apache/struts/pull/791#discussion_r1404381843
##########
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##########
@@ -385,6 +386,7 @@ protected Container
createBootstrapContainer(List<ContainerProvider> providers)
builder.factory(ExpressionCacheFactory.class,
DefaultOgnlExpressionCacheFactory.class, Scope.SINGLETON);
builder.factory(BeanInfoCacheFactory.class,
DefaultOgnlBeanInfoCacheFactory.class, Scope.SINGLETON);
builder.factory(OgnlUtil.class, Scope.SINGLETON);
+ builder.factory(SecurityMemberAccess.class, Scope.PROTOTYPE);
Review Comment:
I wonder if this is a good idea, attacker could get access to the SMA just
by having access to the Container
##########
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##########
@@ -142,6 +142,7 @@ public class DefaultConfiguration implements Configuration {
constants.put(StrutsConstants.STRUTS_OGNL_EXPRESSION_CACHE_MAXSIZE,
10000);
constants.put(StrutsConstants.STRUTS_OGNL_BEANINFO_CACHE_TYPE,
OgnlCacheFactory.CacheType.BASIC);
constants.put(StrutsConstants.STRUTS_OGNL_BEANINFO_CACHE_MAXSIZE,
10000);
+ constants.put(StrutsConstants.STRUTS_ALLOW_STATIC_FIELD_ACCESS,
Boolean.TRUE);
Review Comment:
Is it needed when bootstrapping the framework?
Issue Time Tracking
-------------------
Worklog Id: (was: 892109)
Time Spent: 40m (was: 0.5h)
> Make SecurityMemberAccess extensible and a prototype bean
> ---------------------------------------------------------
>
> Key: WW-5343
> URL: https://issues.apache.org/jira/browse/WW-5343
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
