[ 
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=894076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894076
 ]

ASF GitHub Bot logged work on WW-5141:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Dec/23 14:27
            Start Date: 05/Dec/23 14:27
    Worklog Time Spent: 10m 
      Work Description: jdyer1 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1415702842


##########
apps/showcase/pom.xml:
##########
@@ -145,6 +146,48 @@
 
     <build>
         <plugins>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-dependency-plugin</artifactId>
+              <executions>
+                <execution>
+                  <?m2e ignore?>
+                  <id>copy-dependencies</id>
+                  <phase>package</phase>
+                  <goals>
+                    <goal>copy</goal>

Review Comment:
   @kusalk  I struggled when doing this to figure out how the 
jetty-maven-plugin was building its classpath.  It was not including the 4 jars 
we generate from the Eclipse Transformer, so the showcase integration tests all 
would fail.  The solution I found was to use the Jetty "extraclasspath" feature 
(see same pom.xml lines 236ff) in conjunction with copying the jars as you see 
here.  In my ignorance I may have passed up a more-elegant solution!





Issue Time Tracking
-------------------

    Worklog Id:     (was: 894076)
    Time Spent: 6.5h  (was: 6h 20m)

> Support for JEE 9+ 
> -------------------
>
>                 Key: WW-5141
>                 URL: https://issues.apache.org/jira/browse/WW-5141
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Daniel Le Berre
>            Priority: Major
>             Fix For: 7.0.0
>
>         Attachments: pom.xml
>
>          Time Spent: 6.5h
>  Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to