[ 
https://issues.apache.org/jira/browse/WW-5370?focusedWorklogId=895144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895144
 ]

ASF GitHub Bot logged work on WW-5370:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Dec/23 08:52
            Start Date: 12/Dec/23 08:52
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart commented on code in PR #807:
URL: https://github.com/apache/struts/pull/807#discussion_r1423660030


##########
core/src/main/java/org/apache/struts2/dispatcher/HttpParameters.java:
##########
@@ -100,7 +112,7 @@ public boolean containsValue(Object value) {
 
     @Override
     public Parameter get(Object key) {
-        if (parameters.containsKey(key)) {
+        if (key != null && contains(String.valueOf(key))) {

Review Comment:
   I will use your code and I will add missing equals&hashCode





Issue Time Tracking
-------------------

    Worklog Id:     (was: 895144)
    Time Spent: 1h 40m  (was: 1.5h)

> Make HttpParameters case-insensitive
> ------------------------------------
>
>                 Key: WW-5370
>                 URL: https://issues.apache.org/jira/browse/WW-5370
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 6.4.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently {{HttpParameters}} are case-sensitive which can be misleading



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to