[
https://issues.apache.org/jira/browse/WW-5382?focusedWorklogId=897548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897548
]
ASF GitHub Bot logged work on WW-5382:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jan/24 17:12
Start Date: 01/Jan/24 17:12
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #826:
URL: https://github.com/apache/struts/pull/826#discussion_r1439058168
##########
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java:
##########
@@ -325,12 +325,8 @@ public Class<? extends Configuration> type() {
}
protected ActionContext setContext(Container cont) {
- ActionContext context = ActionContext.getContext();
- if (context == null) {
Review Comment:
This method is only called twice, and it is always null on the first call,
and never null on the second call. I can't see why we wouldn't want to replace
the bootstrap context once the final context has been constructed. Although it
is also unclear if the ActionContext is even used after this point - i.e. for
loading the PackageProviders. The ActionContext is cleared once the
PackageProviders are loaded.
Issue Time Tracking
-------------------
Worklog Id: (was: 897548)
Time Spent: 1h 10m (was: 1h)
> Stale configuration persists after configuration reload
> -------------------------------------------------------
>
> Key: WW-5382
> URL: https://issues.apache.org/jira/browse/WW-5382
> Project: Struts 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.3.0
> Reporter: Kusal Kithul-Godage
> Priority: Major
> Fix For: 6.4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
