[ https://issues.apache.org/jira/browse/WW-5379?focusedWorklogId=897722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897722 ]
ASF GitHub Bot logged work on WW-5379: -------------------------------------- Author: ASF GitHub Bot Created on: 02/Jan/24 19:28 Start Date: 02/Jan/24 19:28 Worklog Time Spent: 10m Work Description: lukaszlenart commented on code in PR #822: URL: https://github.com/apache/struts/pull/822#discussion_r1439750640 ########## plugins/velocity/src/main/java/org/apache/struts2/views/velocity/StrutsVelocityContext.java: ########## @@ -96,11 +96,15 @@ protected Object chainedContextGet(String key) { return null; } for (VelocityContext chainedContext : chainedContexts) { - Object val = chainedContext.internalGet(key); + Object val = chainedContext.get(key); if (val != null) { return val; } } return null; } + + public ValueStack getValueStack() { + return stack; + } Review Comment: It shouldn't change as far I understand, yet I'm not sure if this is true :) Let's leave it as is, at some point I will solve this puzzle ;-) Issue Time Tracking ------------------- Worklog Id: (was: 897722) Time Spent: 1h 50m (was: 1h 40m) > Implement alternative mechanism for Velocity directives to obtain stack > ----------------------------------------------------------------------- > > Key: WW-5379 > URL: https://issues.apache.org/jira/browse/WW-5379 > Project: Struts 2 > Issue Type: Improvement > Components: Plugin - Velocity > Reporter: Kusal Kithul-Godage > Priority: Minor > Fix For: 6.4.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)