[ 
https://issues.apache.org/jira/browse/WW-5352?focusedWorklogId=897755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897755
 ]

ASF GitHub Bot logged work on WW-5352:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Jan/24 06:13
            Start Date: 03/Jan/24 06:13
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart commented on code in PR #829:
URL: https://github.com/apache/struts/pull/829#discussion_r1440104256


##########
core/src/main/java/org/apache/struts2/interceptor/parameter/ParameterNameAware.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.struts2.interceptor.parameter;

Review Comment:
   This is an action related interface and I prefer to put them in 
`org.apache.struts2.action` package - this should avoid users' confusion if 
such interface works with interceptors. wdyt?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 897755)
    Time Spent: 1.5h  (was: 1h 20m)

> Implement annotation mechanism for injectable fields via parameters
> -------------------------------------------------------------------
>
>                 Key: WW-5352
>                 URL: https://issues.apache.org/jira/browse/WW-5352
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core, Core Interceptors
>            Reporter: Kusal Kithul-Godage
>            Priority: Minor
>             Fix For: 6.4.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> struts.parameters.requireAnnotations
>  
> Require an explicit annotation '@StrutsParameter' on one of: 
> Getter/Setter/Field/ReturnType for injecting parameters.
>  
> This mechanism is intended to be a more usable replacement for 
> 'ParameterNameAware'



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to