[
https://issues.apache.org/jira/browse/WW-5381?focusedWorklogId=897825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897825
]
ASF GitHub Bot logged work on WW-5381:
--------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/24 10:33
Start Date: 03/Jan/24 10:33
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #824:
URL: https://github.com/apache/struts/pull/824#discussion_r1440298370
##########
core/src/main/resources/struts-beans.xml:
##########
@@ -174,11 +174,9 @@
<bean type="com.opensymphony.xwork2.util.TextParser" name="struts"
class="com.opensymphony.xwork2.util.OgnlTextParser"
scope="singleton"/>
- <bean type="ognl.ClassResolver"
name="com.opensymphony.xwork2.util.CompoundRoot"
+ <bean type="com.opensymphony.xwork2.ognl.accessor.RootAccessor"
name="struts"
class="com.opensymphony.xwork2.ognl.accessor.CompoundRootAccessor"/>
Review Comment:
Yep very true - looks like our bundled version of Guice is quite old and
doesn't support binding beans to multiple interfaces. Although that might not
work here either since the Bean name has also changed.
I can create a 2nd bean using the old interface and name to prevent
injection failures but obviously this bean won't be the same one used by the
`OgnlValueStackFactory` - it might be fine depending on what these classes
intend to do with the `CompoundRootAccessor` bean, and if they really need it
to share state with the bean injected into `OgnlValueStackFactory`
Issue Time Tracking
-------------------
Worklog Id: (was: 897825)
Time Spent: 2h 20m (was: 2h 10m)
> Introduce extension points for CompoundRootAccessor and MethodAccessor
> ----------------------------------------------------------------------
>
> Key: WW-5381
> URL: https://issues.apache.org/jira/browse/WW-5381
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
