[jira] [Work logged] (WW-5365) Radio tag does not support value objects of type Boolean when setting the default value

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5365?focusedWorklogId=898314&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898314
 ]

ASF GitHub Bot logged work on WW-5365:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jan/24 10:45
            Start Date: 07/Jan/24 10:45
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #835:
URL: https://github.com/apache/struts/pull/835#issuecomment-1880021741

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=835) 
**Quality Gate passed**  
   The SonarCloud Quality Gate passed, but some issues were introduced.
   
   [19 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=835&resolved=false&inNewCodePeriod=true)
  
   [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=835&resolved=false&inNewCodePeriod=true)
  
   [87.7% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=835&metric=new_coverage&view=list)
  
   [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=835&metric=new_duplicated_lines_density&view=list)
  
     
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=835)
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 898314)
    Time Spent: 0.5h  (was: 20m)

> Radio tag does not support value objects of type Boolean when setting the 
> default value
> ---------------------------------------------------------------------------------------
>
>                 Key: WW-5365
>                 URL: https://issues.apache.org/jira/browse/WW-5365
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Tags
>    Affects Versions: 6.3.0
>            Reporter: Nate
>            Priority: Major
>             Fix For: 6.4.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Github proof of concept project here: https://github.com/ikannak/RadioPoC
> The fix for WW-5192 introduced a regression when using a Boolean type value 
> object in a s:radio tag. When using a radio map as shown in the linked PoC 
> project in index.jsp, Struts 2 6.0.3 and later won't set the checked property 
> of the relevant radio input. This appears to be because the value is now 
> considered a String rather than an Object, leading to parameters.nameValue 
> being set to the property name rather than the value of the underlying 
> object. In Struts versions before 6.0.3 (tested with 2.5.32 and 2.5.22), it 
> would use the boolean true/false version of the value object as nameValue, 
> but when tested with version 6.3.0.1, it instead is set to the literal value 
> of the s:radio value attribute.
> Note that this also does not match the official documentation: according to 
> the official tag developers guide at 
> https://struts.apache.org/tag-developers/tag-syntax#value-is-an-object, value 
> is intended to be an object. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)