[ https://issues.apache.org/jira/browse/WW-5357?focusedWorklogId=900593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-900593 ]
ASF GitHub Bot logged work on WW-5357: -------------------------------------- Author: ASF GitHub Bot Created on: 19/Jan/24 06:41 Start Date: 19/Jan/24 06:41 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #848: URL: https://github.com/apache/struts/pull/848#issuecomment-1899852308 ## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=848) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=848&resolved=false&inNewCodePeriod=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=848&resolved=false&inNewCodePeriod=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=848&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=848) Issue Time Tracking ------------------- Worklog Id: (was: 900593) Time Spent: 20m (was: 10m) > Struts anchor tag doesn't support "disabled" even though docs indicate it does > ------------------------------------------------------------------------------ > > Key: WW-5357 > URL: https://issues.apache.org/jira/browse/WW-5357 > Project: Struts 2 > Issue Type: Bug > Components: Core Tags > Affects Versions: 2.5.26 > Reporter: Michael Hum > Priority: Major > Fix For: 6.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Hello there, > When generating an anchor tag with the "disabled" attribute and the simple > theme, struts does not seem to render it properly: > {code} > <%@taglib prefix="s" uri="/struts-tags" %> > ... > <s:a action="myAction" cssClass="btn btn-default" disabled="true"> > <s:param name="myParam" value="#bean.Value"/> > <s:text name="my.properties.key"/> > </s:a> > {code} > The generated link does not contain expected disabled="disabled". > The value is described in the TLD and is documented on the site > https://struts.apache.org/tag-developers/a-tag : > {code:xml} > <attribute> > <description><![CDATA[Set the html disabled attribute on rendered html > element]]></description> > <name>disabled</name> > <required>false</required> > <rtexprvalue>false</rtexprvalue> > </attribute> > {code} > It looks like it's missing from the .ftl file? I added it manually as a > work-around with an overridden template, but perhaps I missed something. We > are admittedly on an old version of struts but I didn't see any differences > in the current version of the git repo. > {code} > <#if parameters.disabled!false> > disabled="disabled"<#rt/> > </#if> > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)