[
https://issues.apache.org/jira/browse/WW-5407?focusedWorklogId=913565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-913565
]
ASF GitHub Bot logged work on WW-5407:
--------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/24 05:06
Start Date: 09/Apr/24 05:06
Worklog Time Spent: 10m
Work Description: kusalk commented on PR #911:
URL: https://github.com/apache/struts/pull/911#issuecomment-2044155603
Hi @lukaszlenart
@jefferyxhy is a colleague of mine at Atlassian who is helping implement
some security enhancements.
I believe this one is ready for review now. I've given it a look over and it
looks good to me. Let us know if there are any issues otherwise we can prepare
an accompanying struts-site PR
Issue Time Tracking
-------------------
Worklog Id: (was: 913565)
Time Spent: 1h 20m (was: 1h 10m)
> Extend SecurityMemberAccess proxy detection to Hibernate proxies
> ----------------------------------------------------------------
>
> Key: WW-5407
> URL: https://issues.apache.org/jira/browse/WW-5407
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.5.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The current option {{struts.disallowProxyMemberAccess}} does not have any
> logic to detect Hibernate proxies which may also present a security risk.
> Additionally, the current option only forbids access to members which
> originate from a proxy. However, it makes more sense to forbid access to
> proxy objects entirely. This is because proxying is often used for sensitive
> instances, application beans or Hibernate objects. None of which is safe to
> be accessed or manipulated via OGNL. Thus, let's introduce an additional
> option {{struts.disallowProxyObjectAccess}} which will offer stronger
> protection.
> Finally, the caching mechanism in the ProxyUtil class uses an unbounded map,
> this can potentially be attacked and lead to a memory leak or DoS. Let's
> replace it with a Caffeine cache as we have done previously for the OGNL
> expression cache.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
