[
https://issues.apache.org/jira/browse/WW-5440?focusedWorklogId=925820&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925820
]
ASF GitHub Bot logged work on WW-5440:
--------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/24 12:20
Start Date: 14/Jul/24 12:20
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #986:
URL: https://github.com/apache/struts/pull/986#discussion_r1677121558
##########
plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ShowConfigAction.java:
##########
@@ -98,16 +104,17 @@ public PropertyDescriptor[] getProperties() {
return properties;
}
+ @Override
public String execute() throws Exception {
super.execute();
config = configHelper.getActionConfig(namespace, actionName);
- actionNames = new
TreeSet<String>(configHelper.getActionNames(namespace));
+ actionNames = new TreeSet<>(configHelper.getActionNames(namespace));
try {
Object action = objectFactory.buildAction(actionName, namespace,
config, null);
properties = reflectionProvider.getPropertyDescriptors(action);
} catch (Exception e) {
- LOG.error("Unable to get properties for action " + actionName, e);
- addActionError("Unable to retrieve action properties: " +
e.toString());
+ LOG.error("Unable to get properties for action {}", actionName, e);
Review Comment:
So I double checked this because IntelliJ insisted this was correct despite
the JavaDoc for the method suggesting it was incorrect. Turns out Log4J 2 will
actually log this correctly as it will identify that the last argument is an
exception (also tested locally). Here is the relevant Log4J 2 code -
https://github.com/apache/logging-log4j2/blob/rel/2.23.1/log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableParameterizedMessage.java#L128
And the relevant documentation -
https://logging.apache.org/log4j/2.x/manual/api.html#substituting-parameters
Issue Time Tracking
-------------------
Worklog Id: (was: 925820)
Time Spent: 1.5h (was: 1h 20m)
> Fix OGNL allowlist compatibility with Convention plugin
> -------------------------------------------------------
>
> Key: WW-5440
> URL: https://issues.apache.org/jira/browse/WW-5440
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Convention
> Affects Versions: 6.4.0
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.6.0, 7.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
