[jira] [Work logged] (WW-5465) Rename tag's parameters into attributes

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5465?focusedWorklogId=937766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937766
 ]

ASF GitHub Bot logged work on WW-5465:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Oct/24 08:46
            Start Date: 13/Oct/24 08:46
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #1067:
URL: https://github.com/apache/struts/pull/1067#issuecomment-2408888000

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1067) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [75.2% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1067&metric=new_coverage&view=list)
 (required ≥ 80%)  
     
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1067)
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 937766)
    Time Spent: 20m  (was: 10m)

> Rename tag's parameters into attributes
> ---------------------------------------
>
>                 Key: WW-5465
>                 URL: https://issues.apache.org/jira/browse/WW-5465
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Tag's parameters can be confused with HttpParameters, but these are two 
> different things and shouldn't be mixed up due to security reasons.
> Using "attributes" instead of "parameters" can allow to distinguish these two 
> sets of data.
> Once introduced templates should use "attributes.${attrName}" instead of 
> "parameters.${paramName}", eg.:
> {code:java}
> <#if attributes.id??>
>  id="${attributes.id}"<#rt/>
> </#if> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)