[
https://issues.apache.org/jira/browse/WW-5501?focusedWorklogId=949769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-949769
]
ASF GitHub Bot logged work on WW-5501:
--------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/24 11:53
Start Date: 23/Dec/24 11:53
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #1156:
URL: https://github.com/apache/struts/pull/1156#discussion_r1895666639
##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequest.java:
##########
@@ -169,4 +176,12 @@ protected String getCanonicalName(final String
originalFileName) {
return fileName;
}
+ protected boolean isAccepted(String fileName) {
+ return patternsChecker.isAllowed(fileName).isAllowed();
+ }
+
+ protected String sanitizeNewlines(String before) {
Review Comment:
Although given this is a protected method, deleting it would be a breaking
change so only thing we could really do is replace the implementation with
`return StringUtils.normalizeSpace(before);`
Issue Time Tracking
-------------------
Worklog Id: (was: 949769)
Time Spent: 1h 20m (was: 1h 10m)
> Exclude malicious names
> -----------------------
>
> Key: WW-5501
> URL: https://issues.apache.org/jira/browse/WW-5501
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 6.7.1, 7.1.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
