[ 
https://issues.apache.org/jira/browse/WW-5528?focusedWorklogId=955819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955819
 ]

ASF GitHub Bot logged work on WW-5528:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Feb/25 09:48
            Start Date: 06/Feb/25 09:48
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart commented on code in PR #1215:
URL: https://github.com/apache/struts/pull/1215#discussion_r1944419694


##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##########
@@ -154,10 +142,10 @@
 
     protected void processNormalFormField(FileItem item, String charset) 
throws UnsupportedEncodingException {
         try {
-            LOG.debug("Item is a normal form field");
+            String fieldName = item.getFieldName();
+            LOG.debug("Item: {} is a normal form field", fieldName);

Review Comment:
   Shouldn't this be sanitized as well? 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 955819)
    Time Spent: 1h 10m  (was: 1h)

> Multipart uploads with invalid characters in file or field name are silently 
> dropped
> ------------------------------------------------------------------------------------
>
>                 Key: WW-5528
>                 URL: https://issues.apache.org/jira/browse/WW-5528
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 6.7.2, 7.0.2
>            Reporter: Kusal Kithul-Godage
>            Priority: Major
>             Fix For: 7.0.3, 6.7.3
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> They should instead be reported as errors via MultiPartRequest#getErrors



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to