[ 
https://issues.apache.org/jira/browse/WW-5531?focusedWorklogId=957858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957858
 ]

ASF GitHub Bot logged work on WW-5531:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Feb/25 06:19
            Start Date: 20/Feb/25 06:19
    Worklog Time Spent: 10m 
      Work Description: kusalk commented on code in PR #1225:
URL: https://github.com/apache/struts/pull/1225#discussion_r1962921998


##########
pom.xml:
##########
@@ -183,6 +183,15 @@
                 </pluginManagement>
             </build>
         </profile>
+        <profile>
+            <id>jdk9plus</id>
+            <activation>
+                <jdk>[9,)</jdk>
+            </activation>
+            <properties>
+                <maven.compiler.release>8</maven.compiler.release>

Review Comment:
   `8` and `1.8` are equivalent
   
   The options mean slightly different things, the `release` option is required 
to ensure bytecode compatibility
   [Here](https://stackoverflow.com/a/65655542/14093292) is a good overview 
from StackOverflow





Issue Time Tracking
-------------------

    Worklog Id:     (was: 957858)
    Time Spent: 40m  (was: 0.5h)

> Enforce JRE8 compatibility for Struts 6.x
> -----------------------------------------
>
>                 Key: WW-5531
>                 URL: https://issues.apache.org/jira/browse/WW-5531
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 6.7.3
>            Reporter: Kusal Kithul-Godage
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to