[
https://issues.apache.org/jira/browse/WW-5532?focusedWorklogId=958479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-958479
]
ASF GitHub Bot logged work on WW-5532:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/25 13:53
Start Date: 24/Feb/25 13:53
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #1232:
URL: https://github.com/apache/struts/pull/1232#discussion_r1967682401
##########
pom.xml:
##########
@@ -900,52 +806,12 @@
</dependency>
<dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>${jackson.version}</version>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
+ <groupId>com.fasterxml.jackson</groupId>
+ <artifactId>jackson-bom</artifactId>
<version>${jackson.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
- <version>${jackson.version}</version>
- </dependency>
-
- <dependency>
- <groupId>org.apache.juneau</groupId>
- <artifactId>juneau-marshall</artifactId>
- <version>8.1.3</version>
- </dependency>
Review Comment:
Why did you remove this dependency from <dependencyManagement/> section?
##########
plugins/rest/pom.xml:
##########
@@ -58,6 +58,7 @@
<dependency>
<groupId>org.apache.juneau</groupId>
<artifactId>juneau-marshall</artifactId>
+ <version>8.1.3</version>
Review Comment:
Version is already defined in the parent pom
Issue Time Tracking
-------------------
Worklog Id: (was: 958479)
Time Spent: 1h (was: 50m)
> Upgrade and align various dependencies
> --------------------------------------
>
> Key: WW-5532
> URL: https://issues.apache.org/jira/browse/WW-5532
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 7.0.3
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 7.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Dependencies:
> * Spring: {{6.0.13}} -> {{6.2.3}}
> * Hibernate-Validator: {{8.0.1.Final}} -> {{8.0.2.Final}}
> Adopt BOMs:
> * {{jakarta.platform:jakarta.jakartaee-bom}}
> * {{org.springframework:spring-framework-bom}}
> * {{org.apache.logging.log4j:log4j-bom}}
> * {{com.fasterxml.jackson:jackson-bom}}
> Test dependencies:
> * ByteBuddy: {{1.16.1}} -> {{1.17.1}}
> * Mockito: {{5.8.0}} -> {{5.15.2}}
> * AssertJ: {{3.26.3}} -> {{3.27.3}}
> * TestNG: {{7.5.1}} -> {{7.11.0}}
> Remove or minimise usages of test dependencies:
> * {{org.springframework:spring-test:4.3.0.RELEASE}} ->
> {{com.github.h-thurow:simple-jndi}}
> * EasyMock
> * Mockobjects
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
