[jira] [Work logged] (WW-5376) struts2-bom should not pull in non-struts dependencies from struts2-parent

Mon, 24 Feb 2025 18:16:09 -0800 


     [ 
https://issues.apache.org/jira/browse/WW-5376?focusedWorklogId=958601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-958601
 ]

ASF GitHub Bot logged work on WW-5376:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Feb/25 02:14
            Start Date: 25/Feb/25 02:14
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #1234:
URL: https://github.com/apache/struts/pull/1234#issuecomment-2680209841

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1234) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [7 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1234&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [71.3% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1234&metric=new_coverage&view=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [E Security Rating on New 
Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1234) 
(required ≥ A)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [C Reliability Rating on New 
Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1234) 
(required ≥ A)  
     
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1234)
   
   ##   
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 '') Catch issues before they fail your Quality Gate with our IDE extension 
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 '') [SonarQube for 
IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 958601)
    Time Spent: 0.5h  (was: 20m)

> struts2-bom should not pull in non-struts dependencies from struts2-parent
> --------------------------------------------------------------------------
>
>                 Key: WW-5376
>                 URL: https://issues.apache.org/jira/browse/WW-5376
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Tyler King
>            Priority: Minor
>             Fix For: 6.8.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The parent of struts-bom pom file is the struts2-parent pom file. The 
> struts2-parent pom file includes a dependencyManagement section with many 
> non-struts dependencies (including test dependencies such as junit and 
> mockito), which are inherited in the struts-bom pom file. This is bad 
> practice for a bom file since consumers of that bom will have versions for 
> dependencies unrelated to struts locked down.
> See [https://www.garretwilson.com/blog/2023/06/14/improve-maven-bom-pattern] 
> and [https://github.com/apache/logging-log4j2] for an example of how they 
> have both parent and bom pom files



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to