[ 
https://issues.apache.org/jira/browse/WW-5256?focusedWorklogId=995043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-995043
 ]

ASF GitHub Bot logged work on WW-5256:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Dec/25 09:54
            Start Date: 06/Dec/25 09:54
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart opened a new pull request, #1446:
URL: https://github.com/apache/struts/pull/1446

   ## Summary
   
   Renames configuration constants from `struts.compress.*` to 
`struts.tag.compress.*` to align with the established pattern for tag-specific 
configuration in Apache Struts.
   
   **Rationale**: The compress tag configuration should follow the 
`struts.tag.*` namespace pattern used for tag-specific settings (similar to 
`struts.tag.includetag.useResponseEncoding`), rather than a generic 
feature-level namespace or the UI component namespace (`struts.ui.*`).
   
   ## Changes
   
   - **StrutsConstants.java**: Updated 3 constant values:
     - `STRUTS_COMPRESS_ENABLED` → `"struts.tag.compress.enabled"`
     - `STRUTS_COMPRESS_MAX_SIZE` → `"struts.tag.compress.maxSize"`
     - `STRUTS_COMPRESS_LOG_MAX_LENGTH` → `"struts.tag.compress.log.maxLength"`
   
   - **default.properties**: Updated 3 property keys to match new namespace
   
   - **Compress.java**: Updated JavaDoc reference to new property name
   
   - **Documentation**: Updated all references in implementation plan
   
   ## Namespace Patterns
   
   - `struts.tag.*` - Tag-specific configuration (e.g., `<s:compress>`, 
`<s:include>`)
   - `struts.ui.*` - UI component cross-cutting concerns (themes, templates)
   - `struts.freemarker.*` - Template engine configuration
   
   ## Test Plan
   
   - [x] All existing CompressTest tests pass (18/18)
   - [x] No old `struts.compress.*` references remain in codebase
   - [x] Configuration injection works correctly with new property names
   - [x] `struts.freemarker.whitespaceStripping` remains unchanged
   
   ## Notes
   
   These changes were introduced in PR #1418 but not yet released, so no 
deprecation cycle is needed.
   
   Closes [WW-5256](https://issues.apache.org/jira/browse/WW-5256)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)




Issue Time Tracking
-------------------

    Worklog Id:     (was: 995043)
    Time Spent: 3h 40m  (was: 3.5h)

> Reduce size of generate html out of freemarker tag templates
> ------------------------------------------------------------
>
>                 Key: WW-5256
>                 URL: https://issues.apache.org/jira/browse/WW-5256
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Tags
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.2.0
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Currently tags are producing a lot of white-space characters and line breaks 
> due to how Freemarker handles all the white-space characters. This can be 
> improved by using a few helpful directtives:
> [https://freemarker.apache.org/docs/dgui_misc_whitespace.html]
> One of them is the 
> [<#compress>|https://freemarker.apache.org/docs/dgui_misc_whitespace.html#autoid_30]
>  directive.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to