[
https://issues.apache.org/jira/browse/WW-5610?focusedWorklogId=1004714&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1004714
]
ASF GitHub Bot logged work on WW-5610:
--------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/26 02:20
Start Date: 12/Feb/26 02:20
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #1565:
URL: https://github.com/apache/struts/pull/1565#discussion_r2796447922
##########
core/src/main/java/com/opensymphony/xwork2/interceptor/MethodFilterInterceptor.java:
##########
@@ -98,8 +98,8 @@ public Set<String> getIncludeMethodsSet() {
@Override
public String intercept(ActionInvocation invocation) throws Exception {
- if (applyInterceptor(invocation)) {
- return doIntercept(invocation);
+ if (applyInterceptor((org.apache.struts2.ActionInvocation)
invocation)) {
Review Comment:
It's a little tricky to follow at first, but we call into
`#applyInterceptor(struts2.ActionInvocation)` which itself calls into
`#applyInterceptor(xwork2.ActionInvocation)`. Thus an extending class can
override either of these methods and it will still have the intended overriding
effect.
Thus legacy applications which are still overriding
`#applyInterceptor(xwork2.ActionInvocation)` will continue to work with no
changes required. And applications that wish to prepare for Struts 7 can update
their override to the new method signature.
Issue Time Tracking
-------------------
Worklog Id: (was: 1004714)
Time Spent: 40m (was: 0.5h)
> Extend Struts 7 forwards compatibility to further interceptors
> --------------------------------------------------------------
>
> Key: WW-5610
> URL: https://issues.apache.org/jira/browse/WW-5610
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.9.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
