[
https://issues.apache.org/jira/browse/WW-5514?focusedWorklogId=1006471&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1006471
]
ASF GitHub Bot logged work on WW-5514:
--------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/26 08:33
Start Date: 21/Feb/26 08:33
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #1573:
URL: https://github.com/apache/struts/pull/1573#discussion_r2835984225
##########
core/src/main/resources/org/apache/struts2/default.properties:
##########
@@ -247,6 +247,14 @@ struts.ognl.beanInfoCacheType=wtlfu
### application-specific needs.
struts.ognl.beanInfoCacheMaxSize=10000
+### Specifies the type of cache to use for proxy detection in ProxyUtil.
+### Valid values: basic, lru, wtlfu. Default is 'basic' (no Caffeine
dependency required).
+### Use 'wtlfu' for better eviction policy if Caffeine is available.
+struts.proxy.cacheType=basic
Review Comment:
fixed
Issue Time Tracking
-------------------
Worklog Id: (was: 1006471)
Time Spent: 3h 10m (was: 3h)
> Allow configuration of ProxyUtil for cache types
> ------------------------------------------------
>
> Key: WW-5514
> URL: https://issues.apache.org/jira/browse/WW-5514
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 6.6.0
> Reporter: Jon Pulice
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 6.9.0, 7.2.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Since 6.6.0, the ProxyUtil class now always uses the WTLFU cache type when
> creating its two internal caches. This means that the caffeine
> library is now mandatory when it was not before.
> {code:java}
> private static final OgnlCache<Class<?>, Boolean> isProxyCache = (new
> DefaultOgnlCacheFactory(10000, OgnlCacheFactory.CacheType.WTLFU, 256))
> .buildOgnlCache();
> private static final OgnlCache<Member, Boolean> isProxyMemberCache = (new
> DefaultOgnlCacheFactory(10000, OgnlCacheFactory.CacheType.WTLFU, 256))
> .buildOgnlCache();{code}
>
> Prior to 6.6.0, setting both of these configuration options would allow you
> to omit the caffeine dependency from an application:
> {code:java}
> <constant name="struts.ognl.expressionCacheType" value ="basic" />
> <constant name="struts.ognl.beanInfoCacheType" value="basic" />{code}
>
> Would it be possible to allow for the cache type used by the ProxyUtil class
> to be configurable as well similar to the above?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
