[jira] [Work logged] (WW-4858) JSONInterceptor must not populate value stack directly

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-4858?focusedWorklogId=1028826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1028826
 ]

ASF GitHub Bot logged work on WW-4858:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Jul/26 19:54
            Start Date: 08/Jul/26 19:54
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #1773:
URL: https://github.com/apache/struts/pull/1773#issuecomment-4918669598

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1773) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [2 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1773&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1773&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1773&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [90.4% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1773&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1773&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1028826)
    Time Spent: 20m  (was: 10m)

> JSONInterceptor must not populate value stack directly
> ------------------------------------------------------
>
>                 Key: WW-4858
>                 URL: https://issues.apache.org/jira/browse/WW-4858
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - JSON
>    Affects Versions: 2.3.1, 6.1.1
>            Reporter: Yasser Zamani
>            Assignee: Lukasz Lenart
>            Priority: Major
>              Labels: decouple, refactoring
>             Fix For: 7.3.0
>
>         Attachments: StrutsUnifiedDataModel.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {{JSONInterceptor}} must populate value stack via OGNL to honor our 
> exclusions!
> So according to my current quick view and understanding, I'm planning 
> something like below which also resolves WW-3364: {{JSONInterceptor}} could 
> be an extension of {{ModelDrivenInterceptor}} via some refactoring of both. 
> From hereafter, {{JSONPopulator}} could be removed and {{JSONInterceptor}} 
> must give population up to {{ParametersInterceptor}}. This simply could be 
> achieved by something like pushing {{JSONInterceptor.root}} into top of stack 
> and also moving posted json to http params (or if was impossible some 
> refactoring of {{ParametersInterceptor}}).
> Please cast here any objections, votes or idea.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)