[
https://issues.apache.org/jira/browse/WW-5642?focusedWorklogId=1029571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1029571
]
ASF GitHub Bot logged work on WW-5642:
--------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/26 10:34
Start Date: 12/Jul/26 10:34
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on PR #1774:
URL: https://github.com/apache/struts/pull/1774#issuecomment-4950857046
Thanks — the creator-bound gap is real and worth closing. As it stands
though the coverage isn't complete: it handles records/`@JsonCreator` via
`withValueDeserializer`, but primitive/required creator components (rejection
returns `null`), collection-path handling, and the broader creator styles
(`@ConstructorProperties`, `@JsonCreator` constructors, top-level records,
collection/map creator params) aren't covered or tested. I'd want those
addressed before it lands.
Are you planning to extend it, or would you prefer I take it forward under a
linked JIRA?
Issue Time Tracking
-------------------
Worklog Id: (was: 1029571)
Time Spent: 0.5h (was: 20m)
> @StrutsParameter authorization bypassed for record/creator-bound REST body
> properties
> -------------------------------------------------------------------------------------
>
> Key: WW-5642
> URL: https://issues.apache.org/jira/browse/WW-5642
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - REST
> Affects Versions: 7.2.1
> Environment: Reproducible with struts2-rest-plugin,
> struts.parameters.requireAnnotations
> enabled, and any REST action whose request body binds a Java record
> (or @JsonCreator/@ConstructorProperties type) either at the top level
> or nested. JDK 17, Jackson 2.22.0.
> Reporter: Gouri Sankar A
> Priority: Major
> Fix For: 7.3.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> ParameterAuthorizingModule enforces @StrutsParameter on REST/JSON body
> deserialization by wrapping each Jackson property's deserializeAndSet /
> deserializeSetAndReturn (AuthorizingSettableBeanProperty). Jackson never
> calls either method for creator-bound properties — Java records,
> @JsonCreator constructors, @ConstructorProperties — it calls the final
> SettableBeanProperty#deserialize directly, which the existing wrapper
> cannot intercept.
> With struts.parameters.requireAnnotations enabled, any record-typed
> field in a REST action's request body is populated with no
> @StrutsParameter check at all, silently defeating the protection for
> that entire subtree.
> Fix: wrap the property's value deserializer (the only non-final
> interception point for the creator-bound path), scoped to
> CreatorProperty so existing setter/field/builder paths are unaffected.
> Fixed by: https://github.com/apache/struts/pull/1774
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
