[
https://issues.apache.org/jira/browse/WW-5645?focusedWorklogId=1030006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1030006
]
ASF GitHub Bot logged work on WW-5645:
--------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/26 06:38
Start Date: 13/Jul/26 06:38
Worklog Time Spent: 10m
Work Description: arunmanni-ai commented on PR #1777:
URL: https://github.com/apache/struts/pull/1777#issuecomment-4955128210
Hi @lukaszlenart,
The CI failures are from two new tests I added for encoded traversal
(`%2e%2e`) in `DefaultWebJarUrlProvider`. The `canonicalisePath()` method
currently catches literal `..` but not percent-encoded variants.
I'm planning to add a check at the top of `canonicalisePath()` to reject
paths containing `%2e` (case-insensitive) before the segment splitting. This
keeps `buildPath()` untouched and doesn't change its contract.
Wanted to check with you first — does that approach align with the design
intent, or would you prefer handling it differently?
Issue Time Tracking
-------------------
Worklog Id: (was: 1030006)
Time Spent: 1h 10m (was: 1h)
> Canonicalise static content paths and remove redundant URL decode
> -----------------------------------------------------------------
>
> Key: WW-5645
> URL: https://issues.apache.org/jira/browse/WW-5645
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 7.2.1
> Reporter: Arun Manni
> Priority: Minor
> Fix For: 7.3.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> buildPath() in DefaultStaticContentLoader applies URLDecoder.decode() to
> resource paths that the servlet container has already decoded. This redundant
> decode serves no purpose and conflicts with the servlet spec's path handling
> contract.
> This patch removes the unnecessary decode and the now-unused encoding
> field/setter, adds a Validator.canonicalisePath() utility that normalises the
> path (resolves . and .., converts \ to /) and returns Optional.empty() when
> the resolved path escapes above root, wires the canonical path through both
> findStaticResource() and the WebJar split() so downstream lookups use the
> normalised form, documents the encoding contract on
> RequestUtils.getServletPath(), and adds test coverage.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
