Lukasz Lenart created WW-5658:
---------------------------------
Summary: Remove deprecated getMessage/findMessage delegators in
AbstractLocalizedTextProvider
Key: WW-5658
URL: https://issues.apache.org/jira/browse/WW-5658
Project: Struts 2
Issue Type: Improvement
Components: Core
Reporter: Lukasz Lenart
Fix For: 8.0.0
h2. Summary
Remove the {{protected}} methods in
{{org.apache.struts2.text.AbstractLocalizedTextProvider}} that were deprecated
for removal in 7.3.0:
* {{getMessage(String bundleName, Locale locale, String key, ValueStack
valueStack, Object[] args)}}
* {{findMessage(Class<?> clazz, String key, String indexedKey, Locale locale,
Object[] args, Set<String> checked, ValueStack valueStack)}}
h2. Background
WW-5540 introduced a raw-resolution + caching path in
{{AbstractLocalizedTextProvider}}. The two methods above were superseded by the
internal raw twins ({{getRawMessage}} + {{formatMessage}} and
{{findMessageRaw}} + the cached {{resolveClassHierarchyRaw}}). To preserve
behavior for subclasses that call or override them, they were kept as thin
delegators and annotated {{@Deprecated(since = "7.3.0", forRemoval = true)}}
rather than deleted.
Because both methods are {{protected}}, they are part of the subclass-facing
API. Removing them is a breaking change and therefore must land in a major
release, not in a minor/patch.
h2. Scope
* Delete the two deprecated delegator methods and their {{@deprecated}} javadoc.
* Remove any now-unused private helpers left behind once the delegators are
gone (verify none are still referenced).
* Ensure no framework code paths still call the removed methods (the current
{{findText}} path already uses the raw resolvers).
* Update tests that invoke the deprecated methods to call the supported raw
path (or drop them if redundant).
h2. Acceptance criteria
* Both {{@Deprecated(forRemoval = true)}} methods are gone.
* The module compiles with no references to the removed methods.
* Existing i18n behavior and tests pass unchanged.
h2. Notes
* Target: next major release (8.0.0).
* Related: WW-5540 (introduced the deprecation), WW-5655 (internal result-type
refactor of the same resolution path).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
