[ 
https://issues.apache.org/jira/browse/WW-5706?focusedWorklogId=1038666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1038666
 ]

ASF GitHub Bot logged work on WW-5706:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Aug/26 06:48
            Start Date: 30/Aug/26 06:48
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #1881:
URL: https://github.com/apache/struts/pull/1881#issuecomment-5467231433

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1881) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [69.2% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1881&metric=new_coverage&view=list)
 (required ≥ 80%)  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1038666)
    Time Spent: 40m  (was: 0.5h)

> RestfulActionMapper does not apply the action name validation used by 
> DefaultActionMapper
> -----------------------------------------------------------------------------------------
>
>                 Key: WW-5706
>                 URL: https://issues.apache.org/jira/browse/WW-5706
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Lukasz Lenart
>            Priority: Major
>             Fix For: 6.12.0, 7.4.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> {{RestfulActionMapper.getMapping()}} derives the action name directly from 
> the request URI ({{actionName = uri.substring(1, nextSlash)}}), whereas 
> {{DefaultActionMapper}} normalizes and validates the action name through 
> {{cleanupActionName}} against the {{allowedActionNames}} pattern.
> Align {{RestfulActionMapper}} with {{DefaultActionMapper}} so both apply the 
> same action-name handling.
> {{Restful2ActionMapper}} already extends {{DefaultActionMapper}} and inherits 
> this behaviour, so no change is needed there.
> Add a regression test covering the aligned handling.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to