[jira] [Work logged] (WW-5720) AuthorizingSettableAnyProperty logs one WARN per rejected dynamic key

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5720?focusedWorklogId=1041750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1041750
 ]

ASF GitHub Bot logged work on WW-5720:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/26 17:23
            Start Date: 15/Sep/26 17:23
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #1948:
URL: https://github.com/apache/struts/pull/1948#issuecomment-5684834223

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1948) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1948&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1948&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1948&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [96.2% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1948&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1948&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1041750)
    Time Spent: 0.5h  (was: 20m)

> AuthorizingSettableAnyProperty logs one WARN per rejected dynamic key
> ---------------------------------------------------------------------
>
>                 Key: WW-5720
>                 URL: https://issues.apache.org/jira/browse/WW-5720
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - REST
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 7.4.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Follow-up to WW-5712.
> When {{struts.rest.anySetter.requireAnnotations}} is enabled, 
> {{AuthorizingSettableAnyProperty.rejectPermission}} and {{rejectDepth}} emit 
> a WARN for every rejected dynamic key. For the existing 
> {{AuthorizingSettableBeanProperty}} a per-property WARN is fine, because the 
> set of property names is bounded by the target class's declared members. For 
> an any-setter the key space is whatever the request body contains, so the 
> number of WARN lines written per request is bounded only by the body itself: 
> a body with ten thousand unknown keys against an unannotated sink produces 
> ten thousand WARN lines.
> Log once per body instead. Suggested shape:
> * keep the per-key detail at DEBUG;
> * count rejections per request in the same request-scoped state that 
> {{DynamicKeyAuthorizationContext}} already holds, and emit a single WARN with 
> the count and the sink (target class plus member) when the scope is cleared 
> at the end of the mapper read, which both Jackson handlers already do in a 
> {{finally}};
> * keep the distinct messages for the three rejection reasons (missing 
> consent, depth exceeded, creator-parameter form), since they point at 
> different fixes on the application side.
> The rejection behaviour itself does not change; only the log volume does.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)