[
https://issues.apache.org/jira/browse/WW-5713?focusedWorklogId=1042186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1042186
]
ASF GitHub Bot logged work on WW-5713:
--------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/26 05:04
Start Date: 17/Sep/26 05:04
Worklog Time Spent: 10m
Work Description: lukaszlenart opened a new pull request, #339:
URL: https://github.com/apache/struts-site/pull/339
Documents [WW-5713](https://issues.apache.org/jira/browse/WW-5713)
(apache/struts#1890, follow-up apache/struts#1961) on the Tiles plugin page:
- new **Legacy OGNL expressions** section after *I18N*: what the `OGNL`
prefix is, why it differs from `S2` (evaluates against the Tiles request,
outside the Struts OGNL controls), that it fails closed with an
`EvaluationException` as from 7.4.0, the `S2:` migration path, and the
per-application `struts.tiles.ognl.legacy.enabled` opt-in with its once-only
warning and deprecation
- **Settings** table with the new constant
No removal version is named, matching the source.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Issue Time Tracking
-------------------
Worklog Id: (was: 1042186)
Time Spent: 1h 20m (was: 1h 10m)
> Fail closed for legacy Tiles OGNL evaluation
> --------------------------------------------
>
> Key: WW-5713
> URL: https://issues.apache.org/jira/browse/WW-5713
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tiles
> Reporter: Karan Kurani
> Priority: Major
> Fix For: 7.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The Struts Tiles plugin registers separate {{S2:}} and legacy {{OGNL:}}
> attribute-expression evaluators.
> The {{S2:}} evaluator processes ValueStack expressions through the Struts
> OGNL facilities. The legacy {{OGNL:}} evaluator evaluates against the Tiles
> {{Request}} and does not use the Struts OGNL security controls used by
> {{{}S2:{}}}.
> This hardening change keeps {{OGNL:}} registered but makes it fail closed by
> default. Evaluation throws Tiles {{EvaluationException}} with migration
> guidance directing users to {{{}S2:{}}}.
> Applications that temporarily require the existing raw behavior may
> explicitly set:
> {{struts.tiles.ognl.legacy.enabled=true}}
> The compatibility flag defaults to {{false}} and is targeted for removal in
> Struts 8.0.0.
> The raw evaluator and its global {{OgnlRuntime}} {{Request}}
> property-accessor setup are constructed only when legacy mode is explicitly
> enabled. This avoids mutating the shared OGNL runtime for applications using
> the secure default.
> When legacy mode is enabled, the existing raw behavior is preserved and a
> clear startup migration warning is emitted.
> {{{}S2:{}}}, {{{}I18N:{}}}, and {{EL:}} remain unchanged.
> Tests cover:
> * default fail-closed behavior;
> * exact migration guidance;
> * non-evaluation of expression markers;
> * construction gating;
> * absence of global accessor initialization under the default;
> * explicit legacy compatibility behavior;
> * startup warning behavior; and
> * real servlet-backed {{S2:}} evaluation.
> This is defense-in-depth hardening. No attacker-controlled expression source
> or concrete vulnerability impact has been demonstrated, and no security
> advisory is proposed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
