[ 
https://issues.apache.org/jira/browse/WW-3472?focusedWorklogId=1046788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1046788
 ]

ASF GitHub Bot logged work on WW-3472:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Oct/26 14:12
            Start Date: 10/Oct/26 14:12
    Worklog Time Spent: 10m 
      Work Description: lukaszlenart opened a new pull request, #350:
URL: https://github.com/apache/struts-site/pull/350

   Refers to [WW-3472](https://issues.apache.org/jira/browse/WW-3472)
   
   The SiteMesh plugin was deprecated in 6.7.0 
([WW-5471](https://issues.apache.org/jira/browse/WW-5471)) and removed in 7.0.0 
([WW-5472](https://issues.apache.org/jira/browse/WW-5472)), but its page gave 
no hint of that. The earlier "deprecated" banner was dropped in 976bde06d, and 
the plugins index left its status cell empty.
   
   - `plugins/sitemesh/index.md`: warning banner stating the page applies to 
versions before 7.0.0 and pointing to the 
[sitemesh3](https://github.com/apache/struts-examples/tree/main/sitemesh3) 
example, which integrates SiteMesh 3 directly with Struts 7 (same pointer as 
`announce-2024.md`). The existing content is kept for users on older versions.
   - `plugins/index.md`: fills in the SiteMesh row, `< 7.0.0` / `deprecated 
since 6.7.0, removed since 7.0.0`, matching the style of the other removed 
plugins.
   
   The rest of WW-3472 (rewriting the SiteMesh 2 examples for 2.2.1) is no 
longer worth doing, since the plugin is gone.
   
   Verified with a local `jekyll build`: the banner renders as 
`blockquote.alert.alert-warning` and the table row renders correctly.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)




Issue Time Tracking
-------------------

            Worklog Id:     (was: 1046788)
    Remaining Estimate: 0h
            Time Spent: 10m

> SiteMesh Plugin document improvements
> -------------------------------------
>
>                 Key: WW-3472
>                 URL: https://issues.apache.org/jira/browse/WW-3472
>             Project: Struts 2
>          Issue Type: Task
>          Components: Documentation
>    Affects Versions: 2.2.1
>            Reporter: Roland McIntosh
>            Priority: Minor
>             Fix For: 7.5.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the SiteMesh Plugin document contains much duplicated information 
> regarding web.xml configuration.  Some of the information, like the section 
> entitled "Velocity," has errors in its example configuration (copy/paste 
> errors that incorrectly reference FreeMarker).
> * The "Full Integration" section references WW-3296, but any relevant/useful 
> information should be extracted from that ticket and used in the document 
> directly.
> Furthermore, the page neglects to give actual SiteMesh configuration 
> examples.  The 2.0.14 docs had a limited example, but this can be improved by 
> adding a section on sitemesh.xml, a simple decorators.xml file (in the case 
> when a ConfigDecoratorMapper is defined), a simple decorator, and a page to 
> be decorated.  These should be FreeMarker or Velocity examples to highlight 
> the new functionality that Struts 2.2.1 affords.
> In general the page could be more clear for newbies.
> Current version:
> http://struts.apache.org/2.x/docs/sitemesh-plugin.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to