[
https://issues.apache.org/jira/browse/WW-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lukasz Lenart updated WW-5775:
------------------------------
Description:
h2. Problem
WW-5772 adds targeted tests for {{optiontransferselect}} and {{updownselect}}
that assert no inline event handler is rendered and that a header key
containing a quote is emitted escaped in a {{data-struts-*}} attribute. There
is no equivalent for:
* {{inputtransferselect}} — {{data-struts-header-key}} on the move up/down
buttons
* {{combobox}} (simple and html5) — no inline {{onChange}}, the select carries
the {{data-struts-combobox}} marker, and the binding script carries the nonce
Today a regression in those templates is caught only by the expected-output
fixture files, which tend to be regenerated wholesale when a template changes.
h2. Proposal
Add intent-revealing assertions for both tags, mirroring the ones WW-5772 adds
to {{OptionTransferSelectTagTest}} and {{UpDownSelectTagTest}}.
Note: {{inputtransferselect}} is deprecated in 7.5.0 (WW-5777) and removed in
8.0.0 (WW-5776), so its part only covers the 7.x line. {{combobox}} stays.
Related: WW-5772
was:
h2. Problem
WW-5772 adds targeted tests for {{optiontransferselect}} and {{updownselect}}
that assert no inline event handler is rendered and that a header key
containing a quote is emitted escaped in a {{data-struts-*}} attribute. There
is no equivalent for:
* {{inputtransferselect}} — {{data-struts-header-key}} on the move up/down
buttons
* {{combobox}} (simple and html5) — no inline {{onChange}}, the select carries
the {{data-struts-combobox}} marker, and the binding script carries the nonce
Today a regression in those templates is caught only by the expected-output
fixture files, which tend to be regenerated wholesale when a template changes.
h2. Proposal
Add intent-revealing assertions for both tags, mirroring the ones WW-5772 adds
to {{OptionTransferSelectTagTest}} and {{UpDownSelectTagTest}}.
Note: these tags are candidates for removal in 8.0.0; if that happens first,
this ticket can be closed with them.
Related: WW-5772
> Add intent tests for inputtransferselect and combobox markup without inline
> handlers
> ------------------------------------------------------------------------------------
>
> Key: WW-5775
> URL: https://issues.apache.org/jira/browse/WW-5775
> Project: Struts 2
> Issue Type: Task
> Components: Unit Tests
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 7.5.0
>
>
> h2. Problem
> WW-5772 adds targeted tests for {{optiontransferselect}} and {{updownselect}}
> that assert no inline event handler is rendered and that a header key
> containing a quote is emitted escaped in a {{data-struts-*}} attribute. There
> is no equivalent for:
> * {{inputtransferselect}} — {{data-struts-header-key}} on the move up/down
> buttons
> * {{combobox}} (simple and html5) — no inline {{onChange}}, the select
> carries the {{data-struts-combobox}} marker, and the binding script carries
> the nonce
> Today a regression in those templates is caught only by the expected-output
> fixture files, which tend to be regenerated wholesale when a template changes.
> h2. Proposal
> Add intent-revealing assertions for both tags, mirroring the ones WW-5772
> adds to {{OptionTransferSelectTagTest}} and {{UpDownSelectTagTest}}.
> Note: {{inputtransferselect}} is deprecated in 7.5.0 (WW-5777) and removed in
> 8.0.0 (WW-5776), so its part only covers the 7.x line. {{combobox}} stays.
> Related: WW-5772
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
