[jira] [Work logged] (WW-5780) html5 theme checkboxlist never closes the checkbox input element

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5780?focusedWorklogId=1047748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1047748
 ]

ASF GitHub Bot logged work on WW-5780:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Oct/26 05:59
            Start Date: 16/Oct/26 05:59
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #2025:
URL: https://github.com/apache/struts/pull/2025#issuecomment-6209145311

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2025) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2025&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2025&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=2025&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2025&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2025&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1047748)
    Time Spent: 20m  (was: 10m)

> html5 theme checkboxlist never closes the checkbox input element
> ----------------------------------------------------------------
>
>                 Key: WW-5780
>                 URL: https://issues.apache.org/jira/browse/WW-5780
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Tags
>            Reporter: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.5.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The {{html5}} theme template {{template/html5/checkboxlist.ftl}} emits each 
> {{<input type="checkbox" ...}} without a closing {{/>}} — the 
> {{dynamic-attributes.ftl}} include is followed directly by {{<label}}.
> Rendering {{<s:checkboxlist theme="html5" name="collection" list="list" 
> listKey="top[0]" listValue="top[1]" cssClass="myClass" 
> cssStyle="width:150px"/>}} produces:
> {code:html}<input type="checkbox" name="collection" value="hello" 
> id="collection-1" class="myClass" style="width:150px" class="myClass" 
> style="width:150px"<label for="collection-1" 
> class="checkboxLabel">world</label>
> {code}
> The browser parses {{<label}}, {{for}} and {{class}} as attribute names of 
> the input, so no {{label}} element is created: clicking the item text does 
> not toggle the checkbox and assistive technology loses the label.
> Present since the html5 theme was added (WW-5444), i.e. released in 7.2.0. 
> {{CheckboxListTest.testGenericHtml5}} only checks that expected substrings 
> appear, so it does not catch malformed markup.
> Fix: close the input as {{template/html5/radiomap.ftl}} already does, and add 
> a full expected-output fixture for the html5 checkboxlist.
> The duplicated {{class}}/{{style}} attributes in the output above are tracked 
> separately.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)