[jira] [Work logged] (WW-3666) TypeConverter should trim before conversion to things that are not Strings

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-3666?focusedWorklogId=1048005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1048005
 ]

ASF GitHub Bot logged work on WW-3666:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Oct/26 08:30
            Start Date: 17/Oct/26 08:30
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #2039:
URL: https://github.com/apache/struts/pull/2039#issuecomment-6231767236

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2039) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2039&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2039&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=2039&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [95.3% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2039&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2039&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1048005)
    Time Spent: 40m  (was: 0.5h)

> TypeConverter should trim before conversion to things that are not Strings
> --------------------------------------------------------------------------
>
>                 Key: WW-3666
>                 URL: https://issues.apache.org/jira/browse/WW-3666
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Value Stack
>    Affects Versions: 2.2.1.1
>         Environment: Standard Struts2 implementation with Jetty
>            Reporter: adam brin
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 7.5.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> For a simple struts2 application, when you pass in parameters that are not 
> "Strings" for example Longs or Enums the Xwork2 TypeConverter (and Struts2's 
> handling) needs some work.
> Issues:
> * numeric values are not properly parsed if they have space characters
> * enum values are not properly parsed if they have space characters
> * ideally some exception would bubble back up in the form of an ActionError
> Attached (in comments) is a simple controller and test case using HTMLUnit to 
> demonstrate the issue.  Even with the following logger settings, no errors 
> are visible:
> {noformat}log4j.logger.org.apache.struts2=TRACE
> log4j.logger.com.opensymphony.xwork2=TRACE
> {noformat} 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)