[jira] [Work logged] (WW-5819) Log a validator param that fails type conversion instead of ignoring it silently

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5819?focusedWorklogId=1050325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1050325
 ]

ASF GitHub Bot logged work on WW-5819:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Oct/26 15:08
            Start Date: 26/Oct/26 15:08
    Worklog Time Spent: 10m 
      Work Description: sonarqubecloud[bot] commented on PR #2062:
URL: https://github.com/apache/struts/pull/2062#issuecomment-6419480428

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=2062) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2062&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=2062&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=2062&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [84.6% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2062&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=2062&metric=new_duplicated_lines_density&view=list)
  
     
   <!

Issue Time Tracking
-------------------

    Worklog Id:     (was: 1050325)
    Time Spent: 50m  (was: 40m)

> Log a validator param that fails type conversion instead of ignoring it 
> silently
> --------------------------------------------------------------------------------
>
>                 Key: WW-5819
>                 URL: https://issues.apache.org/jira/browse/WW-5819
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: XML Validators
>            Reporter: Lukasz Lenart
>            Priority: Major
>             Fix For: 7.5.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> h2. Problem
> {{DefaultValidatorFactory}} builds each validator through 
> {{ObjectFactory.buildValidator}}, which sets the configured params with type 
> conversion errors swallowed. A param that cannot be converted is left unset, 
> and nothing is logged. For a range bound, that turns the check off without 
> any trace:
> {code:xml}<field-validator type="localdate">
>     <param name="min">01/02/2026</param>  <!-- not an ISO date: min stays 
> null -->
> </field-validator>
> {code}
> h2. Proposal
> Keep the current behaviour (the validator is still built and the param is 
> still left unset), but log the swallowed conversion error. The message names 
> the validator type, the param, the value and the cause:
> * WARN by default
> * ERROR in devMode
> h2. Scope
> A logging-only change with no behaviour change, so it is safe for 7.5.0. 
> Failing the configuration instead is WW-5818 (8.0.0).
> h2. Tests
> * an unconvertible param on an XML-configured validator produces the log 
> entry at the expected level, and the validator is still built
> * a valid param produces no entry



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)